Typescript strict config #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
added
FY25 Sprint 15
|
Tests are passing - merging PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Applies strict typescript configuration to the project as we do in the spa frontend repo.
Now properties of an interface that are declared as
string | undefinedorstring | nullorproperty?: stringfor example, are treated as both values, so we can write more safe code now.This PR also accommodate the code everywhere where after this config change, typescript was complaining because we weren't taking care of possibly undefined or null values, some values are casted with the
askeyword because there where previous checks and it was safe to cast them.Which issue(s) this PR closes:
Suggestions on how to test this:
Visual code inspection and validate that Github Action checks are OK.