Add extra parameter to transform or not html to markdown #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-saracca
added
Size: 3
pdurbin
reviewed
Oct 22, 2024
Co-authored-by: Philip Durbin <[email protected]>
Co-authored-by: Philip Durbin <[email protected]>
cmbz
added
FY25 Sprint 8
Hmm, good question, I'm not sure about the test:coverage action here, maybe @GPortas has some insights about this? |
|
We discussed code coverage and created another issue to add it to Github actions. #208 |
ekraffmiller
approved these changes
Oct 29, 2024
|
Re-ran tests in Jenkins and did visual code inspection. No issues found - merging pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
An additional parameter is added to the
getDatasetandgetPrivateUrlDatasetuse cases to configure whether we want the values of the metadata fields containing html to be transformed into markup or not.Which issue(s) this PR closes:
Suggestions on how to test this:
Code visual inspection. Run tests.