Fixed locate particles #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if it is set to 1.0
…nymore for sendtorank and recvfromrank
…pile_definitions().
aaadelmann
approved these changes
Apr 1, 2025
srikrrish
requested changes
Apr 2, 2025
| namespace ippl { | ||
|
|
||
| /*! | ||
| * We need this struct since Kokkos parallel_scan only accects |
| locate_type particleRanks("particles' MPI ranks", localnum); | ||
|
|
||
| /* The indices are the indices of the particles, | ||
| * the boolean values describe wheather the particle has left the current rank |
There was a problem hiding this comment.
Ok, I've fixed the typos.
srikrrish
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request consists of several related changes.
The most significant part is the changes to
locateParticles()insrc/Particle/ParticleSpatialLayout.hpp. This fixes Fix bug in modified locateParticles #273 and extends the original idea (veronica_report_v3_1.pdf) by making thempi::rma::Windowa memeber variable that is only initialized once per rank.The change in
alpine/LoadBalancer.hppallows disabling the loadbalancing completely by setting the threshold to1.0and addition of a timer to track initializationstatic IpplTimings::TimerRef initializeTimer = IpplTimings::getTimer("initialize")