Tkl/dev/hdnext 1719/hdnext 1762 remove fa submodules - #246
Merged
printminion-co merged 4 commits intoMay 7, 2026
Conversation
hidrive-next-build.yml: remove custom-npms/** path trigger and FONTAWESOME_PACKAGE_TOKEN from the build step. sbom-matrix.yaml: remove FONTAWESOME_PACKAGE_TOKEN secret requirement and custom-npm pre-install steps from the npm install job. Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
This reverts commit e739552.
Remove all four custom-npm submodules to support FA icon embedding pipeline: - nc-mdi-svg: FA-to-MDI SVG embedding (primary FA integration point) - nc-mdi-js: thin wrapper over @mdi/js, only customized to use nc-mdi-svg - nc-nextcloud-vue: thin fork of @nextcloud/vue, only wired custom icon packages - nc-vue-material-design-icons: FA mapping logic, now redundant without FA Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
bromiesTM
approved these changes
May 7, 2026
printminion-co
merged commit May 7, 2026
a08a8ee
into
mk/dev/HDNEXT-1588-backport-commits
7 of 12 checks passed
printminion-co
deleted the
tkl/dev/HDNEXT-1719/HDNEXT-1762_remove-FA-submodules
branch
May 7, 2026 13:33
printminion-co
added a commit
that referenced
this pull request
May 11, 2026
After rebasing onto ionos-dev-v32.0.6 (which removed FA Pro / custom-npms submodules via PR #246), the workflow still referenced custom-npms infra that no longer exists. Three minimum-viable stubs: - check_custom_npms: always emit cached=true (skips build-custom-npms job) - build-custom-npms make step: replace build_custom_npms call with `true` (defensive — job is gated off, but force_rebuild could still trigger it) - hidrive-next-build custom-npms restore: `if: false` (nothing to restore) The build-custom-npms job and its downstream references remain in place as inert wiring; a future PR can remove them along with the matching needs_custom_npms field in detect-app-cache.sh / generate_apps_matrix_json.
bromiesTM
restored the
tkl/dev/HDNEXT-1719/HDNEXT-1762_remove-FA-submodules
branch
June 17, 2026 06:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist