build: Add sass:icons step to nextcloud dev build - #150
Merged
Conversation
npm dev and build purge the dist folder automatically but build has a postbuild step to generate icons.css. This is missing for dev script Signed-off-by: Kai Henseler <kai.henseler@strato.de>
There was a problem hiding this comment.
Pull request overview
Adds the missing icon stylesheet generation step to the Nextcloud development build target so the dev build produces the same icons.css artifact that production builds already generate via the build pipeline.
Changes:
- Extend
build_nextcloud_devto runnpm run sass:iconsafternpm run dev. - Keep the dev build flow consistent with the existing production build’s icon CSS generation behavior.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm dev and build purge the dist folder automatically but build has a postbuild step to generate icons.css. This is missing for dev script