paper: the sentences package's low findings, the real ones fixed - #153
Merged
Merged
Conversation
Ornate nouns, a discourse marker, a negative parallelism, two false ranges, a contrast tail and the idiolect word are gone, and the tricolons that read as lists are shortened. What remains at low severity is the package reading clause commas as series.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pass with the package at every severity, not only the gated ones. Fixed: "ecosystem", "in practice", "principled", the "not a thunk" reframe, two false ranges, the contrast tail in 6.4, and five tricolons that read as lists. What the package still reports at low severity is three-item comma series that are clause commas, and three from-to phrases that are directions rather than ranges; those stay.