feat(emit): dogfood github-warden Action + prep npm publish - #4
Merged
Merged
Conversation
Replace the npm-install + npx run-steps in the emitted governance workflow with a `uses: intentius/github-warden@<SHA> # v1` action step, SHA-pinned to the v1 commit (GHA029). This eliminates setup-node and npm-install boilerplate and passes all inputs (command, config, mode, app-id, installation-id, private-key, cycles) via with:, keeping the dry-run-on-PR / apply-on-push split and PR-comment behavior intact. Update tests to assert the SHA-pinned uses: reference with # v1 comment, with: inputs, and that setup-node/npm-install are absent. Also prep package.json for npm publish: remove "private", add publishConfig.access=public, files manifest (bin + dist), and prepublishOnly build script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/emit/pipeline.tsnow emitsuses: intentius/github-warden@50db522e57c4ccdb36af932062ee38839bc1b88e # v1steps (SHA-pinned per GHA029,# v1comment for readability). Removed thesetup-node+npm install --global github-warden+npx github-warden reconcilerun-steps; inputs (command,config,mode,app-id,installation-id,private-key,cycles) now pass viawith:. Dry-run-on-PR / apply-on-push split, PR-comment step, least-privilege permissions, andtimeout-minutesare all preserved.package.jsonfor npm publish: removed"private": true, added"publishConfig": { "access": "public" },"files": ["bin", "dist"], and"prepublishOnly": "npm run build".bin/github-warden.jslauncher already committed and loadsdist/cli.js.Test plan
npx tsc --noEmit— clean (no output)npm test— 231 tests pass (11 test files)npm run build— CLI bundle builds todist/cli.jsnpm run build:action— action bundle builds toaction/index.mjsnpm pack --dry-run— tarball containsbin/github-warden.js+dist/cli.js, no "invalid/removed" bin warningnode bin/github-warden.js --help— prints usage against built distuses:with# v1,with:inputs present, nosetup-node/npm installsteps