Skip to content

CI's four prepack lists and tsconfig paths are hand-maintained per lexicon; augur was missing from all five #2376

Description

@lex00

Found while landing #2372 (the augur lexicon, #2357). A new lexicon directory is not enough for CI to build it: the prepack invocations are hand-written lists, one line per lexicon, and there are four of them:

  • .github/workflows/chant.yml check job (~line 58-73)
  • .github/workflows/chant.yml test job (~line 195-210)
  • .github/workflows/chant.yml lexicon-artifacts job (~line 289-343, one named step per lexicon)
  • .github/workflows/publish.yml (~line 72-88)

augur was in none of them, so dist/meta.json never existed on CI and test/lexicon-artifacts.setup.ts:14 refused to start vitest, while tsconfig.json's per-lexicon paths (also hand-written, also missing augur) failed the check job with TS2307. Locally both resolved through the workspace symlink, which is exactly why the author's own gates passed.

Everything else that enumerates lexicons is already dynamic: scripts/check-lexicons.ts, just _ensure-gen/regen, the vitest.config.ts globs, build-docs.sh, test/lexicon-artifacts.ts, publish-packages.sh.

Ask

Either generate the four lists (and the tsconfig.json paths pairs) from ls lexicons/, or add a guard test in the shape of scripts/lexicon-count-claims.test.ts (#2339) that fails when a directory under lexicons/ is absent from any of the five. The guard is the smaller change and catches the next one the day it's added; #2372 added augur by hand to all five.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area:ciCI, release, publishchoreRoutine maintenance — pin bumps, chores

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions