Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: Use java 17 for tests #6107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

I-Al-Istannen
Copy link
Collaborator

Previously spoon-pom used not-existent properties to configure the maven compiler, which tripped up intellij. This patch consistently uses maven.compiler.(test)Release.

Previously spoon-pom used not-existent properties to configure the maven
compiler, which tripped up intellij. This patch consistently uses
maven.compiler.(test)Release.
@I-Al-Istannen I-Al-Istannen changed the title wip: fix: Use java 17 for tests review: Use java 17 for tests Dec 17, 2024
@SirYwell
Copy link
Collaborator

We set java.src.version for one mvn call in flake.nix, I assume this doesn't affect anything anymore this way? And it also seems like SpoonPom is using this option but doesn't consider the release flag...

@MartinWitt
Copy link
Collaborator

@SirYwell How is the evaluation progressing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants