Extraction and Transformation of Ibtracs #210
Merged
+178
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudan45
force-pushed
the
feature/ibtracs-extraction
branch
2 times, most recently
from
0f43aef to
35d0d99
Compare
tnagorra
reviewed
Mar 20, 2025
sample.env
Outdated
| @@ -1,13 +1,23 @@ | |||
| DJANGO_SECRET_KEY=test | |||
There was a problem hiding this comment.
Please undo this change. We no longer need sample.env
tnagorra
reviewed
Mar 20, 2025
| @@ -339,7 +342,7 @@ | |||
| SENTRY_DSN = env("SENTRY_DSN") | |||
| SENTRY_ENABLED = False | |||
| SENTRY_MONITOR_CELERY_BEAT_TASKS = env("SENTRY_MONITOR_CELERY_BEAT_TASKS") | |||
| if SENTRY_DSN: | |||
| if SENTRY_DSN is not None: | |||
tnagorra
reviewed
Mar 20, 2025
helm/values-test.yaml
Outdated
| @@ -27,6 +27,7 @@ env: | |||
| USGS_DATA_URL: https://usgs.dummy.com | |||
| EMDAT_URL: https://emdat.dummy.com | |||
|
|
|||
| IBTRACS_DATA_URL: https://ibtracs.com | |||
There was a problem hiding this comment.
Suggested change
| IBTRACS_DATA_URL: https://ibtracs.com | |
| IBTRACS_DATA_URL: https://ibtracs.dummy.com |
tnagorra
reviewed
Mar 20, 2025
|
|
||
| @staticmethod | ||
| @app.task | ||
| def task(extraction_id): |
There was a problem hiding this comment.
Suggested change
| def task(extraction_id): | |
| def task(extraction_id: int): |
tnagorra
reviewed
Mar 20, 2025
|
|
||
| @staticmethod | ||
| @app.task | ||
| def task(DATA_URL): |
There was a problem hiding this comment.
Suggested change
| def task(DATA_URL): | |
| def task(url: str): |
tnagorra
reviewed
Mar 20, 2025
tnagorra
requested changes
Mar 20, 2025
tnagorra
force-pushed
the
feature/ibtracs-extraction
branch
2 times, most recently
from
1ec7023 to
3e283ab
Compare
- Update transformation of ibtracs - Update env variable in helm chart - Update source task and collection - Update geocoder in basehandler
tnagorra
force-pushed
the
feature/ibtracs-extraction
branch
from
3e283ab to
ce47131
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
This PR doesn't introduce any:
printThis PR contains valid: