Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class bases ETL for Glide, Emdat. #208

Merged
merged 4 commits into from
Mar 20, 2025
Merged

Conversation

Rup-Narayan-Rajbanshi
Copy link
Contributor

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi commented Mar 14, 2025

Addresses

Depends on

Changes

  • Add class based etl for glide.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi changed the base branch from develop to feature/separate-historical-and-latest-extraction March 14, 2025 10:53
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi changed the base branch from feature/separate-historical-and-latest-extraction to project/separate-historical-and-latest-extraction March 14, 2025 10:57
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/apply-class-based-etl branch from d115cb1 to 280a069 Compare March 14, 2025 10:58
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the project/separate-historical-and-latest-extraction branch from 37d6cc7 to 1dab3b0 Compare March 17, 2025 11:21
Base automatically changed from project/separate-historical-and-latest-extraction to develop March 18, 2025 10:57
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/apply-class-based-etl branch from e06c951 to ecd874b Compare March 19, 2025 08:47
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi changed the title Class bases ETL Class bases ETL for Glide, Emdat. Mar 19, 2025
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/apply-class-based-etl branch from ecd874b to 15f9e69 Compare March 19, 2025 09:10
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi marked this pull request as ready for review March 19, 2025 09:11
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/apply-class-based-etl branch 2 times, most recently from 2757a22 to 6a0945f Compare March 19, 2025 11:15
@@ -11,4 +11,4 @@ class Command(BaseCommand):
help = "Import data from EM-DAT"

def handle(self, *args, **options):
ext_and_transform_emdat_historical_data.delay()
ext_and_transform_emdat_historical_data()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove delay?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed delay here as it has chain(EMDATExtraction.task.s(QUERY, variables), EMDATTransformHandler.task.s()).apply_async() running internally which is asynchronous.

@tnagorra tnagorra force-pushed the feature/apply-class-based-etl branch 2 times, most recently from bb83195 to bf5fb82 Compare March 20, 2025 08:07
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/apply-class-based-etl branch 3 times, most recently from f6b8170 to 9bb07c5 Compare March 20, 2025 08:42
  - Add start date from env variable for gdacs, glide, emdat, ifrc
  - Load pystac item with status equals to pending.
  - Set conrtab for idu historical data.
  - Fix glide url
  - Send data into pdc transformer in a temp file.
@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi force-pushed the feature/apply-class-based-etl branch 3 times, most recently from 9bc7f0f to ae8ed22 Compare March 20, 2025 10:32
- Re-format graphql query
- Define query variables for emdat and glide
- Simplify logic for glide task
@tnagorra tnagorra merged commit b8fafe3 into develop Mar 20, 2025
3 checks passed
@tnagorra tnagorra deleted the feature/apply-class-based-etl branch March 20, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants