Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide and unhide sections #1615

Open
wants to merge 1 commit into
base: project/dref-imminent-returns
Choose a base branch
from
Open

Hide and unhide sections #1615

wants to merge 1 commit into from
+872 −503

Conversation

barshathakuri
Copy link
Collaborator

Summary

Dref Imminent few sections have been removed

Addresses

Changes

  • Hide sections
  • Change in dref Export

This PR Ensures:

  • No typos or grammatical errors
  • No conflict markers left in the code
  • No unwanted comments, temporary files, or auto-generated files
  • No inclusion of secret keys or sensitive data
  • No console.log statements meant for debugging
  • All CI checks have passed

Additional Notes

  • These changes in dref export is remaining.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7d08bed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shreeyash07 shreeyash07 changed the base branch from develop to project/dref-imminent-returns December 30, 2024 06:09
AdityaKhatri
AdityaKhatri approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@AdityaKhatri AdityaKhatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from technical perspective but needs to be checked from logical perspective by @samshara and @shreeyash07 .

samshara
samshara approved these changes Dec 30, 2024
View reviewed changes
app/src/views/DrefApplicationExport/i18n.json Outdated
@@ -2,6 +2,7 @@
"namespace": "drefApplicationExport",
"strings": {
"exportTitle": "DREF Operation",
"exportDrefImminentTitle": "Imminent DREF operation",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"exportDrefImminentTitle": "Imminent DREF operation",
"exportDrefImminentTitle": "Imminent DREF Operation",

@barshathakuri barshathakuri force-pushed the feature/dref-imminent branch from 15a28f8 to ca91dec Compare January 3, 2025 09:06
@barshathakuri barshathakuri force-pushed the feature/dref-imminent branch from ca91dec to ebc4749 Compare January 3, 2025 10:03
@barshathakuri barshathakuri force-pushed the feature/dref-imminent branch from ebc4749 to 7d08bed Compare January 3, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreeyash07 shreeyash07 shreeyash07 approved these changes

@samshara samshara samshara approved these changes

@AdityaKhatri AdityaKhatri AdityaKhatri approved these changes

@tnagorra tnagorra Awaiting requested review from tnagorra

@frozenhelium frozenhelium Awaiting requested review from frozenhelium

@roshni73 roshni73 Awaiting requested review from roshni73

Assignees

@samshara samshara

@shreeyash07 shreeyash07

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barshathakuri @AdityaKhatri @samshara @shreeyash07