feat: Add learning by sector,regions bar chart and Map for learning #1577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
roshni73
force-pushed
the
feature/add-charts-learnings
branch
from
89e0a01 to
e80e0a5
Compare
samshara
requested changes
Dec 9, 2024
roshni73
force-pushed
the
feature/add-charts-learnings
branch
from
e80e0a5 to
3bde6b9
Compare
roshni73
force-pushed
the
feature/add-charts-learnings
branch
from
3bde6b9 to
3ef7309
Compare
roshni73
force-pushed
the
feature/add-charts-learnings
branch
from
3ef7309 to
a9f5ebb
Compare
roshni73
force-pushed
the
feature/add-charts-learnings
branch
from
a9f5ebb to
3071d1b
Compare
roshni73
force-pushed
the
feature/add-charts-learnings
branch
2 times, most recently
from
6af5950 to
087c25b
Compare
samshara
force-pushed
the
project/operational-learning-2.0
branch
from
94723fb to
c5a62d6
Compare
roshni73
force-pushed
the
feature/add-charts-learnings
branch
from
652d37b to
69f849c
Compare
roshni73
force-pushed
the
feature/add-charts-learnings
branch
from
69f849c to
2b1a8f1
Compare
roshni73
force-pushed
the
feature/add-charts-learnings
branch
from
2b1a8f1 to
13e7220
Compare
roshni73
force-pushed
the
feature/add-charts-learnings
branch
from
13e7220 to
5e1c4da
Compare
shreeyash07
approved these changes
Dec 31, 2024
subinasr
requested changes
Dec 31, 2024
| "strings": { | ||
| "downloadMapTitle": "Operational learning map", | ||
| "learningLegendLabel": "Learnings", | ||
| "learningCountLegendLabel":"Learning count" |
There was a problem hiding this comment.
Let's fix the spacings.
Suggested change
| "learningCountLegendLabel":"Learning count" | |
| "learningCountLegendLabel": "Learning count" |
| import i18n from './i18n.json'; | ||
| import styles from './styles.module.css'; | ||
|
|
||
| type learningStatsResponse = GoApiResponse<'/api/v2/ops-learning/stats/'>; |
There was a problem hiding this comment.
Suggested change
| type learningStatsResponse = GoApiResponse<'/api/v2/ops-learning/stats/'>; | |
| type LearningStatsResponse = GoApiResponse<'/api/v2/ops-learning/stats/'>; |
|
|
||
| interface Props { | ||
| className?: string; | ||
| learning: learningStatsResponse | undefined; |
There was a problem hiding this comment.
Suggested change
| learning: learningStatsResponse | undefined; | |
| learning: LearningStatsResponse | undefined; |
Comment on lines
+97
to
+99
| geometry: country.centroid as { | ||
| type: 'Point', | ||
| coordinates: [0, 0], |
There was a problem hiding this comment.
Let's fix the indentation here.
| footerClassName={styles.footer} | ||
| footerContent={( | ||
| <div className={styles.learningsLegend}> | ||
| <div className={styles.legendLabel}>{strings.learningLegendLabel}</div> |
There was a problem hiding this comment.
Separate the lines here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
Changes
This PR doesn't introduce:
console.logmeant for debugging