project: Move field report title generation logic to server #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4ae480f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
samshara
force-pushed
the
fix/field-report-title-server-generation
branch
from
c7d2eb5 to
a48cd22
Compare
frozenhelium
approved these changes
Dec 2, 2024
samshara
force-pushed
the
fix/field-report-title-server-generation
branch
from
a48cd22 to
3348e90
Compare
tnagorra
requested changes
Dec 24, 2024
| const summaryVisible = !value.is_covid_report; | ||
| const suffixVisible = !fieldReportId && isTruthyString(titleSuffix); | ||
|
|
||
| const preferredColumnNoForSummary = Math.max( |
| value={titlePrefix} | ||
| onChange={() => { }} | ||
| /> | ||
| )} | ||
| {summaryVisible && ( |
There was a problem hiding this comment.
@samshara We should still display the final title from the server.
There was a problem hiding this comment.
Done in the latest commit.
samshara
force-pushed
the
fix/field-report-title-server-generation
branch
from
3348e90 to
0b136d2
Compare
tnagorra
changed the title
tnagorra
changed the title
samshara
force-pushed
the
fix/field-report-title-server-generation
branch
from
2d48508 to
dcd13d3
Compare
samshara
force-pushed
the
fix/field-report-title-server-generation
branch
from
dcd13d3 to
92fa86c
Compare
samshara
force-pushed
the
fix/field-report-title-server-generation
branch
from
b030361 to
4ae480f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
Depends on:
Changes
titlefield will now store the user-provided title for the field report.summaryfield will contain the automatically generated title from the server.This PR doesn't introduce:
console.logmeant for debugging