Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the additional libPaths #9318

Merged

Conversation

N-thony
Copy link
Collaborator

@N-thony N-thony commented Dec 18, 2024

Fixes partially #9314
@rdstern @ChrisMarsh82, as pointed by @rdstern in the issue, when you install/update new packages they go to the user library i.e. C:/Users/rdste/AppData/Roaming/R-Instat/library. Packages here persist across updates of R-Instat unless explicitly removed by deleting the folder.
This PR ensures that a separate directory is created for each version of R-Instat in the Roaming folder (e.g., C:/Users/rdste/AppData/Roaming/R-Instat/0.8.0b/library), also that packages from previous versions don't interfere with the new ones. When updating R-Instat, you would then install new packages in the corresponding version-specific library, keeping older versions isolated.

@N-thony
Copy link
Collaborator Author

N-thony commented Dec 18, 2024

Also, improved the setting of the additional libPaths more cleaner.
image

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@N-thony I am very happy to see this. I note also that you can run multiple copies of R-Instat (and I often do.) So it seems sensible that an older version remains undisturbed when a new version is installed.
I assume that the roaming directories are removed, when R-Instat is uninstalled?
@ChrisMarsh82 I hope you can check the code and approve and merge. Or suggest someone else. I am approving, though I can't see what I can test easily. So over to you?

@N-thony
Copy link
Collaborator Author

N-thony commented Jan 13, 2025

@rdstern @ChrisMarsh82, it will be good if we can get this in the new release.

@rdstern
Copy link
Collaborator

rdstern commented Jan 13, 2025

@N-thony agreed, and this is still a bit early for @ChrisMarsh82 in UK. Let's see later today.

@ChrisMarsh82
Copy link
Contributor

@N-thony @N-thony This looks fine to merge. Sorry for the delay. I did review it Friday but must have missed a click

@ChrisMarsh82 ChrisMarsh82 merged commit 6b61592 into IDEMSInternational:master Jan 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants