Skip to content

feat(ContainerAuthenticator): enhance ContainerAuthenticator to support Code Engine workload #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SaschaSchwarze0
Copy link
Member

This pull request extends the existing ContainerAuthenticator to be aware of the hard-coded compute resource token path used by Code Engine. This allows a seamless usage of that authenticator and a move of workload between IKS/ROKS/Code Engine without changing a single line of code.

Documentation is adjusted to mention Code Engine in the context of the ContainerAuthenticator.

…rt Code Engine workload

Signed-off-by: Sascha Schwarze <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Mar 3, 2025

CLA assistant check
All committers have signed the CLA.

@padamstx padamstx self-requested a review March 6, 2025 23:40
@padamstx padamstx self-assigned this Mar 6, 2025
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx requested a review from dpopp07 March 6, 2025 23:48
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@dpopp07 dpopp07 merged commit 765d33f into IBM:main Mar 7, 2025
9 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Mar 7, 2025
# [3.23.0](v3.22.1...v3.23.0) (2025-03-07)

### Features

* **ContainerAuthenticator:** add support for code engine workload ([#218](#218)) ([765d33f](765d33f))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 3.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants