Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize follower tests #731

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Stabilize follower tests #731

merged 4 commits into from
Nov 1, 2024

Conversation

eiri
Copy link
Member

@eiri eiri commented Oct 31, 2024

PR summary

This PR attempts to stabilize CI for follower's tests.

The list of changes:

  • Better debug messages that doesn't show iterator stop as an exception
  • Shorter timeouts on tests for faster failing on resource starved CI runners
  • Simplify and refactor test runner to do iterations on main loop and run stopper in thread as Timer
  • Switch to lazy-loading generator expression in main thread of follower to avoid memory and CPU overhead in tread's buffer

Fixes: s1060

Note: An existing issue is required before opening a PR.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

The CI occasionally hangs or fails on resource starved containers.

What is the new behavior?

CI should be more stable and fail faster.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

ibmcloudant/features/changes_follower.py Outdated Show resolved Hide resolved
test/unit/features/conftest.py Show resolved Hide resolved
@eiri eiri force-pushed the s1060-fix-stabilize-follower-tests branch from 281f0b9 to ef6997d Compare November 1, 2024 13:42
@eiri eiri force-pushed the s1060-fix-stabilize-follower-tests branch from ef6997d to 41e9ceb Compare November 1, 2024 13:47
@eiri eiri merged commit bd0c946 into main Nov 1, 2024
10 checks passed
@eiri eiri deleted the s1060-fix-stabilize-follower-tests branch November 1, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants