Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: explicit actions permissions #723

Merged
merged 1 commit into from
Oct 24, 2024
Merged

ci: explicit actions permissions #723

merged 1 commit into from
Oct 24, 2024

Conversation

ricellis
Copy link
Member

PR summary

Explicit include of only necessary permissions for actions token.

Fixes: part of s1014

Note: An existing issue is required before opening a PR.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features) - N/A
  • Docs have been added / updated (for bug fixes / features) - N/A

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

Default restrictive token is applied.

What is the new behavior?

permissions: {}
Give the token no additional permissions (the empty set includes metadata: read which is always given).
content: read should not be needed even for checkout since it is a public repository.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ricellis ricellis self-assigned this Oct 23, 2024
@ricellis ricellis merged commit 210e284 into main Oct 24, 2024
10 checks passed
@ricellis ricellis deleted the s1014-action-token branch October 24, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants