Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): requests>=2.32.2,<3.0.0 #677

Merged
merged 1 commit into from
Jul 10, 2024
Merged

build(deps): requests>=2.32.2,<3.0.0 #677

merged 1 commit into from
Jul 10, 2024

Conversation

ricellis
Copy link
Member

PR summary

Restore the requests dependency range now that https://github.com/IBM/python-sdk-core/releases/tag/v3.20.2 is available.

Related to #660 and #676

Note: An existing issue is required before opening a PR.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

Dependency update.

What is the current behavior?

requests dependency is pinned to a small range avoiding the broken 2.32.3 version.

What is the new behavior?

Since the core now has a workaround for the broken behaviour in 2.32.3 we can relax the range again requests>=2.32.2,<3.0.0

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ricellis ricellis self-assigned this Jul 10, 2024
@ricellis ricellis merged commit 9ac4daa into main Jul 10, 2024
10 checks passed
@ricellis ricellis deleted the requests-range branch July 10, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants