skip launch-flow event creation if inconsistent timestamps are deteted - #86
Merged
Merged
Conversation
…ed, print warnings Signed-off-by: Lars Schneidenbach <schneidenbach@us.ibm.com>
lasch
requested review from
WarningRan,
eklee15,
mcalman and
yuhaohaoyu
as code owners
March 16, 2026 17:49
Signed-off-by: Lars Schneidenbach <schneidenbach@us.ibm.com>
lasch
force-pushed
the
tolerant_launch_flow
branch
from
March 16, 2026 17:56
1d072b0 to
c4a90ea
Compare
yuhaohaoyu
reviewed
Mar 25, 2026
yuhaohaoyu
left a comment
yuhaohaoyu
left a comment
Member
There was a problem hiding this comment.
Enhancement of messaging from the tool, lgtm
yuhaohaoyu
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR resolves an issue where inconsistent time stamps would cause assertions during launch-flow creation. This made it harder to handle or debug experimental traces.
With this PR, the assertion is changed so that timestamp inconsistencies are counted and then a summary warning is printed at the end. For example:
If you see this warning, it's recommended to inspect the output (and input) traces for potential causes of these inconsistencies.
The creation of launch flow events is skipped for these inconsistent cases.