fix deviceProperties ingestion when combining multiple torch traces - #69
Merged
Merged
Conversation
Signed-off-by: Lars Schneidenbach <schneidenbach@us.ibm.com>
… from multiple ranks Signed-off-by: Lars Schneidenbach <schneidenbach@us.ibm.com>
Signed-off-by: Lars Schneidenbach <schneidenbach@us.ibm.com>
lasch
requested review from
WarningRan,
eklee15,
mcalman and
yuhaohaoyu
as code owners
December 12, 2025 15:34
mcalman
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because python dict merges are not merging lists by default, any multi-trace processing only contained one deviceProperties entry. This PR fixes that aspect as well as the fact that all input files have device ID of 0. This is now replaced with the rank.
Changes to
tb_refinement.pyare refactoring and using the rank as the device ID instead of the PID of an event.