-
Notifications
You must be signed in to change notification settings - Fork 0
Add region splitting #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can we remove the |
Similarly the changes to setup.cfg, I'm not sure why they are needed in this PR. They look like packaging things that we can do separately? (I think we can do better values for some of them) |
Readme looks great! Lots of detail. We could move some of it into a proper Sphinx docs site later, as then we can have API reference bits generated automatically from Python and doc strings (also add our nice theme). But it's great to have anything more than the current (ie nothing) for now :-) Some minor comments - we can look at those later in a future PR:
As for the code and tests, looks great! The only thing is can we add to the |
Add region splitting functionality
Changes made:
All tests passing.