deprecated methods and make optoout files truly parallel download #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com:IABTechLab/uid2-shared into wzh-UID2-6108-increase-thread-number-optout
lizk886
commented
Sep 24, 2025
lizk886
commented
Sep 24, 2025
lizk886
commented
Sep 25, 2025
| private void cloudUploadBlocking(String fileToUpload) throws Exception { | ||
| String cloudPath = this.cloudSync.toCloudPath(fileToUpload); | ||
| try (InputStream localInput = this.localStorage.download(fileToUpload)) { | ||
| this.cloudStorage.upload(localInput, cloudPath); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
lizk886
commented
Sep 25, 2025
| // Be careful as the s3Path may contain the pre-signed S3 token, so do not log the whole path | ||
| LOGGER.error("download error: " + ex.getClass().getSimpleName()); | ||
| promise.fail(new Throwable(ex)); | ||
| throw ex; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
is the original wrapping new Throwable(ex) on top of ex is because of
// Be careful as the s3Path may contain the pre-signed S3 token, so do not log the whole path ?
lizk886
changed the title
clarkxuyang
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://vertx.io/docs/guides/vertx-5-migration-guide/