Migration of operator code to go/v4 schema #26
Conversation
|
Hi @ShivangGoswami, I am planning to review it tomorrow. I'll keep you posted 🙏 |
There was a problem hiding this comment.
Hi @ShivangGoswami , here a first round: I had some issue building the operator locally and it looks like the issue was in the controller-gen version. Using a newer version seems doing the trick.
There was a problem hiding this comment.
Hi again @ShivangGoswami, thanks for addressing all issues 🚀
I tested on both vanilla kubernetes and openshift cluster and it looks working.
I left just a minor comment on the README (sorry I did not notice this before), but apart from that it looks great to me!
There was a problem hiding this comment.
This one is solved for now. Will try to make readme more understandable in the coming days
No worries at all, I think that's already awesome 🚀
LGTM, thanks a lot again @ShivangGoswami !
@barreiro I leave the final decision to you, mainly to double check that I have not missed anything.
|
@ShivangGoswami thank you for the contribution! |
Issue: #24
The Required generated files and code changes are done in this PR to upgrade the Operator to go/v4
The Reconcile and other logic is carried forwarded from the old code and there is no code changes as such
These code also replaces kube-proxy,controller-gen,envtest,controller-tools to latest version, bumps go version of operator code and also use new schema definition of generated files
Testing:
The Operator was tested on openshift-crc with hyper foil v0.24.2 and is working as expected.