Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clients reference #1633

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Apr 24, 2024

Changes proposed

Update the clients reference documentation based on the following api changes:

They are going to change how the HorreumClient is initialized

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@lampajr
Copy link
Member Author

lampajr commented Apr 24, 2024

I changed the way the HorreumClient needs to be instatiated (in terms of params) because some additional configuration have been required (see linked pull requests for more details)

@lampajr lampajr marked this pull request as ready for review April 24, 2024 16:04
@lampajr lampajr self-assigned this Apr 24, 2024
@lampajr lampajr requested a review from johnaohara April 24, 2024 16:05
@stalep stalep added this to the 0.13 milestone Apr 25, 2024
@stalep stalep merged commit a3ed1b1 into Hyperfoil:master Apr 26, 2024
3 checks passed
@lampajr lampajr deleted the update_clients_doc branch April 26, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants