feat(engine): detect usage of env.storage().instance().update() witho…#482
Merged
Gbangbolaoluwagbemiga merged 2 commits intoHyperSafeD:mainfrom Mar 30, 2026
Conversation
|
@MarvyNwaokobia Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the StorageUpdateStateCheckRule to accurately detect state checks preceding env.storage().instance().update() calls. It now supports:
Match expressions: Recognizes when update() is called inside a match arm where the match expression is a state check.
Sequential checks: Tracks state checks occurring in previous statements within the same function block.
Related Issue
Closes #451
Changes
Updated check_for_vulnerable_update in storage_update_state_check.rs.
Added unit tests for match arms and sequential checks.
Verification
Ran cargo test -p sanctifier-core --lib --no-default-features rules::storage_update_state_check::tests and all tests passed.