Open
Conversation
|
@nonso7 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…ration (HyperSafeD#411) Adds `sanctifier analyze --format junit` which emits a standards-compliant JUnit XML document (testsuites/testsuite/testcase with <failure> elements) mapping every security check category to a test suite. GitLab, CircleCI, and GitHub CI can consume this file in their native test-report tabs. Changes ------- CLI (sanctifier-cli): - New `junit` format branch in analyze::exec; suppresses branding logo (same as json) so output is machine-readable - xml_escape() helper, junit_testsuite() builder, and print_junit_report() covering all 7 check categories (auth_gaps, symbol_issues, panic_issues, arithmetic_issues, storage_collisions, size_warnings, unsafe_patterns) - Added missing [dev-dependencies]: assert_cmd, predicates, tempfile, regex - Fixed field_reassign_with_default, too_many_arguments, unused vars, assert_eq!(bool, false), dead print_banner — all pre-existing Clippy errors Core (sanctifier-core): - Removed unused imports and dead code (has_attr, DEFAULT_APPROACHING_THRESHOLD) - #[derive(Default)] on StorageVisitor and GasEstimator - Simplified with_panic_guard → unwrap_or_default() - Collapsed duplicate if-branches in classify_size() - Fixed doc-comment and empty-line-after-doc warnings - field_reassign_with_default in tests replaced with struct literal init - Removed dead imports from integration_token_test.rs Contracts: - Prefixed unused `admin` variable in vulnerable-contract - Applied rustfmt to kani-poc CI (.github/workflows/rust.yml): - Install cargo-nextest (taiki-e/install-action@nextest) - Run tests with `cargo nextest run --profile ci` to emit JUnit XML - Upload target/nextest/ci/junit.xml as artifact `junit-test-results` with `if: always()` so failures are still reported - Scope clippy to `-p sanctifier-cli -p sanctifier-core` to exclude contract crates whose soroban testutils feature is incompatible with the host runner target New files: - .config/nextest.toml — defines [profile.ci] with junit output path Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
nonso7
force-pushed
the
feat/junit-xml-output
branch
from
2981225 to
ea4cb26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Describe the change, the motivation behind it, and any important implementation details.
Fixes #
Type of change
Testing
List the commands you ran and the scope of validation.
Checklist
mainand merge conflicts are resolved.Closes #411