-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH] Refactor package.json, electron builder and others #1180
base: main
Are you sure you want to change the base?
Conversation
…desktop-client into tech/elec_build_yml
…desktop-client into tech/elec_build_yml
4eef34d
to
c1b5e23
Compare
c1b5e23
to
76fc6f6
Compare
…nstall additional dependencies
…ming/hyperplay-desktop-client into tech/elec_build_yml
…desktop-client into tech/elec_build_yml
Important to test with the artifacts on this PR btw @nyghtstalker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on linux and windows
Yeah, since the Build artifact is not signed, you need to run this command on the macOS terminal first: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could check again running this command your shared and it works fine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff
…desktop-client into tech/elec_build_yml
…ming/hyperplay-desktop-client into tech/elec_build_yml
ad5c3b1
to
ea4e91d
Compare
This pull request includes several important changes to the project's configuration and build process, particularly focusing on the
electron-builder
configuration and thepackage.json
scripts. Below are the most significant changes:Build Configuration:
electron-builder.yml
file to configure the Electron build process..Project Configuration:
build
section frompackage.json
and moved its content to the newelectron-builder.yml
file.Scripts:
scripts
section inpackage.json
to be above thedependencies
.Email Update:
package.json
from[email protected]
to[email protected]
.ESLint Ignore:
.eslintignore
to include additional directories such asbuild
,dist
, andplaywright-report
.HOW TO TEST
Use the following Checklist if you have changed something on the Backend or Frontend: