Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Refactor package.json, electron builder and others #1180

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

flavioislima
Copy link
Contributor

@flavioislima flavioislima commented Dec 3, 2024

This pull request includes several important changes to the project's configuration and build process, particularly focusing on the electron-builder configuration and the package.json scripts. Below are the most significant changes:

Build Configuration:

  • Added a new electron-builder.yml file to configure the Electron build process..

Project Configuration:

  • Removed the build section from package.json and moved its content to the new electron-builder.yml file.

Scripts:

  • Moved the scripts section in package.json to be above the dependencies.

Email Update:

ESLint Ignore:

  • Updated .eslintignore to include additional directories such as build, dist, and playwright-report.

HOW TO TEST

  • Just test if all the builds are working fine (Windows, linux and macOS), no need for full regression since this touches only the build process.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@flavioislima flavioislima marked this pull request as ready for review January 9, 2025 16:02
@flavioislima flavioislima changed the title Tech/elec build yml [TECH] Refactor package.json, electron builder and others Jan 9, 2025
@flavioislima flavioislima self-assigned this Jan 9, 2025
@flavioislima flavioislima added the PR: Ready-For-Review PR is ready to be reviewed by peers label Jan 9, 2025
@BrettCleary
Copy link
Collaborator

Important to test with the artifacts on this PR btw @nyghtstalker

Copy link
Collaborator

@BrettCleary BrettCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on linux and windows

@biliesilva
Copy link
Contributor

biliesilva commented Jan 22, 2025

I'm having this error below on Mac, I tried the installation 4 times, with different downloads and difererent directories, but with this same error:
image

@flavioislima
Copy link
Contributor Author

I'm having this error below on Mac, I tried the installation 4 times, with different downloads and difererent directories, but with this same error

Yeah, since the Build artifact is not signed, you need to run this command on the macOS terminal first:
xattr -d com.apple.quarantine ~/Downloads/HyperPlay.app
(replace the path if the app is in another directory)

Copy link
Contributor

@biliesilva biliesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could check again running this command your shared and it works fine!

Copy link
Contributor

@eliobricenov eliobricenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@BrettCleary BrettCleary added PR: Ready-For-Test PR is ready to be tested by a QA and removed PR: Ready-For-Review PR is ready to be reviewed by peers labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Ready-For-Test PR is ready to be tested by a QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants