Add device id options to connect #377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t options Co-authored-by: zach <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: zach <[email protected]>
Co-authored-by: zach <[email protected]>
Co-authored-by: zach <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying audio input and output devices when connecting to EVI, allowing users to select specific microphones and speakers for their sessions.
Key changes:
- Introduced
DeviceOptionstype withmicrophoneDeviceIdandspeakerDeviceIdfields - Updated
connect()to accept device IDs and pass them to the audio player and microphone initialization - Added device selector UI to the example application demonstrating the new functionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/models/connect-options.ts | Added DeviceOptions type and included it in ConnectOptions |
| packages/react/src/lib/useSoundPlayer.ts | Modified initPlayer to accept and configure speaker device via setSinkId |
| packages/react/src/lib/VoiceProvider.tsx | Updated connect to extract device options and pass them to audio initialization |
| packages/react/README.md | Added documentation for DeviceOptions and formatting improvements |
| packages/react/MIGRATION.md | Formatting changes to markdown (bold text and list styles) |
| examples/next-app/components/ExampleComponent.tsx | Added device enumeration and selector UI to demonstrate device selection |
| README.md | Table formatting alignment fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yinishi
reviewed
Oct 27, 2025
| if (audioOutputs.length > 0 && !selectedSpeakerId) { | ||
| setSelectedSpeakerId(audioOutputs[0].deviceId); | ||
| } | ||
| } catch { |
There was a problem hiding this comment.
can we update this to close the microphone stream once we get the device IDs?
yinishi
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
deviceIdtoAudioConstraintsandspeakerDeviceIdtoConnectOptionsto allow users to specify audio input and output devices.Slack Thread