Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LEAP-1356: Add custom button props #6787

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Gondragos
Copy link
Collaborator

Added support for custom button props in buttons and included a data-leave attribute in table rows for unsaved changes checks triggers.

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

… to table row

Added support for custom button props in buttons and included a `data-leave` attribute in table rows for unsaved changes checks triggers.
@github-actions github-actions bot added the feat label Dec 13, 2024
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 1be06b9
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/67735ee51ca1b0000819dd4d

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 1be06b9
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/67735ee59a0eb60008ab12f0

@Gondragos
Copy link
Collaborator Author

Gondragos commented Dec 30, 2024

/git merge develop

Workflow run
Successfully merged: 98 files changed, 2168 insertions(+), 950 deletions(-)

…1356/unsaved-sidebar

# Conflicts:
#	web/libs/datamanager/src/components/Common/Table/TableRow/TableRow.jsx
@Gondragos Gondragos force-pushed the fb-leap-1356/unsaved-sidebar branch from 697a0d9 to 1be06b9 Compare December 31, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant