Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: LEAP-1291: Remove Stale Feature Flag - fflag_fix_front_lsdv_4988_dynamic_no_label_120523_short #6749

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Dec 3, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Removing a FF that was stale for a few months.

WHEN REVIEW
CHECK THE STALE VALUE FIRST

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit cd5b0ac
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/6750b0969bfb4d00085bf67d

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit cd5b0ac
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6750b096f8488c00086dc635

@luarmr luarmr force-pushed the fb-leap-1291/remove-stale-feature-flag---fflagfixfrontlsdv4988dynamicnolabel120523short branch from e05f8f9 to 10bc854 Compare December 3, 2024 17:20
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.77%. Comparing base (83ee25a) to head (cd5b0ac).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6749   +/-   ##
========================================
  Coverage    76.77%   76.77%           
========================================
  Files          170      170           
  Lines        13944    13944           
========================================
  Hits         10706    10706           
  Misses        3238     3238           
Flag Coverage Δ
pytests 76.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luarmr
Copy link
Contributor Author

luarmr commented Dec 4, 2024

/git merge

Workflow run
Successfully merged: create mode 100644 web/libs/frontend-test/src/helpers/utils/fixLSParams.ts

@luarmr
Copy link
Contributor Author

luarmr commented Dec 5, 2024

/git merge

Workflow run
Successfully merged: Already up to date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant