Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to reverse zoom scroll direction in settings #6730

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Zensome
Copy link

@Zensome Zensome commented Nov 27, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

When labeling images, the current zoom behavior is not intuitive, as it's reversed from common applications.
Link to the issue: #6729

label studio:

  • ctrl + scroll up == zoom out
  • ctrl + scroll down == zoom in

other software:

  • ctrl + scroll up == zoom in
  • ctrl + scroll down == zoom out

What does this fix?

(if this is a bug fix)

What is the new behavior?

I added a new parameter into the configuration modal “Reverse zoom scroll direction”, so users can toggle to choose which scrolling direction they want.

They could switch to the new setting, or keep using the previous one if they are used to it.

image

What is the current behavior?

Currently, Ctrl+scroll up zooms out and Ctrl+scroll down zooms in.

What libraries were added/updated?

No new libraries were added or updated.

Does this change affect performance?

No, it does not impact performance.

Does this change affect security?

No, it does not affect security.

What alternative approaches were there?

Changing the scroll direction without setting parameter.

What feature flags were used to cover this change?

feature

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Image Annotation Interface, shortcuts.

Copy link

netlify bot commented Nov 27, 2024

👷 Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a62ec02

Copy link

netlify bot commented Nov 27, 2024

👷 Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a62ec02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant