This repository has been archived by the owner on Apr 18, 2024. It is now read-only.
fix: OPTIC-152: Uploading a text field but only 'true' is showing up not 'false' #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlomzik
suggested changes
Jan 27, 2024
Comment on lines
7
to
8
| /* if undefined or null we'll treat it as empty string, otherwise toString(), this will allow 0 and false to render properly */ | ||
| return (value ?? "").toString(); |
There was a problem hiding this comment.
the same comment as in #295:
what kind of value could be here? it won't fail on null or undefined and that's the only values triggering nullish coalescing.
the issue with false and 0 is fully fixed by next change. but most probably it won't work as expected if you want to return empty string for null and undefined, then you have to check for them specifically.
There was a problem hiding this comment.
I applied a change based on our discussion. i also added a unit test in LS PR
hlomzik
approved these changes
Jan 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
there was an issue where all falsey values would be treated as empty string, which is undesired. this change makes it so 0 and false will render as expected but null and undefined will be treated as empty string