Skip to content

fix(pwa): simplify debt transfer flow#152

Closed
HorusGoul wants to merge 5 commits into
mainfrom
fix/simplify-transfer-form
Closed

fix(pwa): simplify debt transfer flow#152
HorusGoul wants to merge 5 commits into
mainfrom
fix/simplify-transfer-form

Conversation

@HorusGoul
Copy link
Copy Markdown
Owner

Summary

  • Add a debt transfer flow that moves an existing balance from one party to another.
  • Split the experience into party selection, participant selection, and confirmation steps.
  • Update the balances screen to surface a new Transfer debt action for eligible debts.
  • Add E2E coverage plus unit tests for debt transfer logic and party selection helpers.
  • Include release notes and locale updates for the new user-facing flow.

Testing

  • pnpm test not run.
  • pnpm lint not run.
  • pnpm typecheck not run.
  • E2E debt transfer scenario added in packages/pwa/e2e/debt-transfer.spec.ts.

HorusGoul and others added 5 commits April 18, 2026 18:23
Summary:
- add a dedicated debt transfer flow from balance actions to move a
  user's debt into another joined party with same-currency filtering
- create transfer helper logic, destination-party eligibility lookup,
  and name matching with exact auto-selection plus recommendations
- add unit coverage, a Playwright journey, locale updates, and a
  changeset for the new user-facing workflow

Rationale:
- users already recreate these transfers manually, so the feature turns
  a repetitive multi-step workaround into a guided flow
- keeping the implementation as paired expense creation matches the
  existing mental model and avoids extra transfer metadata complexity

Tests:
- pnpm test
- pnpm lint
- pnpm typecheck
- pnpm -C packages/pwa exec playwright test e2e/debt-transfer.spec.ts
- pnpm -C packages/pwa lingui:extract

Co-authored-by: Codex <codex@openai.com>
Signed-off-by: GitHub Actions <actions@github.com>
- Add review and confirmation steps for transferring debt
- Update E2E page object for the new transfer flow
- Refresh English and Spanish copy for the new UI
- Split transfer into party, participant, and confirm steps
- Update E2E coverage and localized copy for the new flow
- Add changelog entry
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 20, 2026

🦋 Changeset detected

Latest commit: ebba69c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@trizum/pwa Minor
@trizum/mobile Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
trizum ebba69c Commit Preview URL

Branch Preview URL
Apr 20 2026, 05:56 PM

@HorusGoul HorusGoul marked this pull request as draft April 22, 2026 13:07
Copy link
Copy Markdown
Owner Author

Superseded by #151. The simplify-transfer work was cherry-picked onto feature/debt-transfer-between-parties so this duplicate PR can be closed.

@HorusGoul HorusGoul closed this Apr 23, 2026
@HorusGoul HorusGoul deleted the fix/simplify-transfer-form branch April 23, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant