Skip to content

Conversation

@lhinuz
Copy link

@lhinuz lhinuz commented May 21, 2019

Fixed block coord bug.

@DreamHollow
Copy link
Contributor

Not sure if this commit actually does anything, just seems to add unnecessary extra math.

@Hopson97
Copy link
Owner

Hopson97 commented Mar 2, 2023

Yeah, I might see if I can test this to see if there is a difference; not sure what this actually is fixing without additional context

@janvanbouwel
Copy link

The % operator is a division remainder and negative numbers stay negative. With the fix they'll be positive so it'll be an actual modulo. A stack overflow answer about it

Double modulo may not be the best idea if that code should be very optimised though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants