-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
Conversation
@@ -0,0 +1,70 @@ | |||
require "FileUtils" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is done automatically. Can cut this line.
9b97a5a
to
5d41a5c
Compare
|
||
# mv this so it is not installed with the other docs | ||
mv "docs/websockify.1", "websockify.1" | ||
man1.install "websockify.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use man1.install "docs/websockify.1"
and you can remove the mv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does man1.install "docs/websockify.1
also remove docs/websockify.1
? If it does, we can remove the mv
. If it doesn't, then the man page will also be installed in the docs
in share
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeh, it does. It's a mv
rather than a cp
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, done.
5d41a5c
to
2708653
Compare
|
||
Dir.chdir("other") do | ||
system "make" | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
system "make", "-C", "other"
Sorry for the delay - implemented changes as requested on 8 Feb. |
@BrewTestBot test this please. |
PLease fix the |
Websockify is a suite of programs to bridge WebSockets to TCP implemented in different languages. It also includes support resources to simplify WebSocket programming for some older browsers.
@BrewTestBot test this please |
The test-bot seems to be ignoring me on this. |
|
||
(share+"websockify"+"ruby").install "other/websocket.rb", "other/websockify.rb" | ||
|
||
(share+"websockify"+"clojure").install "other/project.clj", "other/websockify.clj" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the spacing between all the .installs
that don't have comments above them, thanks!
Ping. |
Presuming dead from lack of response. Please feel free to fix-up various comments and resubmit the PR if you're still interested, but closing here for now. Thanks for the submission! |
Websockify is a suite of programs to bridge WebSockets to TCP
implemented in different languages. It also includes support
resources to simplify WebSocket programming for some older
browsers.