-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm64 CI #278
base: master
Are you sure you want to change the base?
Add arm64 CI #278
Conversation
end | ||
# When we move from Ubuntu 22.04, on ARM we should add a dependency to [email protected] and [email protected]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we keep this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was when the original plan was to not use any glibc dependency and just use the system one (which would make the baseline arm64 minimum be 2.35).
The plan seems to be now to use 2.17 which is a permanent requirement (for as long as reasonable)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bo98 @ZhongRuoyu What version(s) of Ubuntu is using 2.35 vs. 2.17? I think it'd be nicer to just target the GitHub Actions Ubuntu runner version for now, whatever that ends up requiring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
22.04 uses 2.35, though we're not exactly going to stay on 22.04 forever so would need a glibc@whatever
for whatever we end up using.
2.17 would support every single aarch64/arm64 Linux OS out there (to our knowledge). 2.35 would only support OS versions since mid-2022, with no support at all for RHEL (their latest version uses 2.34).
Overall though I don't really mind. Losing RHEL is probably somewhat restrictive though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Losing RHEL for ARM specifically seems fine. I think we should aim to just support Ubuntu >=22.04 for now.
It's likely to be a long time before we're doing anything other than Portable Ruby and Homebrew/brew basic support.
end | ||
# When we move from Ubuntu 22.04, on ARM we should add a dependency to [email protected] and [email protected]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bo98 @ZhongRuoyu What version(s) of Ubuntu is using 2.35 vs. 2.17? I think it'd be nicer to just target the GitHub Actions Ubuntu runner version for now, whatever that ends up requiring.
Everything builds fine. Just one interesting
|
Pending changes in brew first.
Bit of a chicken-egg problem given we don't have an arm64 Homebrew Docker image yet so a temporary bootstrap step is required.