Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm64 CI #278

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add arm64 CI #278

wants to merge 4 commits into from

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Jan 17, 2025

Pending changes in brew first.

Bit of a chicken-egg problem given we don't have an arm64 Homebrew Docker image yet so a temporary bootstrap step is required.

end
# When we move from Ubuntu 22.04, on ARM we should add a dependency to [email protected] and [email protected].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we keep this?

Copy link
Member Author

@Bo98 Bo98 Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was when the original plan was to not use any glibc dependency and just use the system one (which would make the baseline arm64 minimum be 2.35).

The plan seems to be now to use 2.17 which is a permanent requirement (for as long as reasonable)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bo98 @ZhongRuoyu What version(s) of Ubuntu is using 2.35 vs. 2.17? I think it'd be nicer to just target the GitHub Actions Ubuntu runner version for now, whatever that ends up requiring.

Copy link
Member Author

@Bo98 Bo98 Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22.04 uses 2.35, though we're not exactly going to stay on 22.04 forever so would need a glibc@whatever for whatever we end up using.

2.17 would support every single aarch64/arm64 Linux OS out there (to our knowledge). 2.35 would only support OS versions since mid-2022, with no support at all for RHEL (their latest version uses 2.34).

Overall though I don't really mind. Losing RHEL is probably somewhat restrictive though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Losing RHEL for ARM specifically seems fine. I think we should aim to just support Ubuntu >=22.04 for now.

It's likely to be a long time before we're doing anything other than Portable Ruby and Homebrew/brew basic support.

.github/workflows/build.yml Show resolved Hide resolved
end
# When we move from Ubuntu 22.04, on ARM we should add a dependency to [email protected] and [email protected].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bo98 @ZhongRuoyu What version(s) of Ubuntu is using 2.35 vs. 2.17? I think it'd be nicer to just target the GitHub Actions Ubuntu runner version for now, whatever that ends up requiring.

cmd/portable-package.rb Outdated Show resolved Hide resolved
@Bo98
Copy link
Member Author

Bo98 commented Jan 21, 2025

Everything builds fine. Just one interesting brew bottle bug I'll look into:

FormulaUnavailableError: No available formula with the name "formula.jws.json".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants