Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdb: install gdbserver #70284

Closed
wants to merge 1 commit into from
Closed

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented Feb 3, 2021

gdbserver is actually being built by default on Linux, but not being installed. (gdbserver on macOS is not supported.)

I'm using the maybe-install-gdbserver install target to avoid platform-specific instructions. It's a no-op on macOS, but installs the built gdbserver on Linux.

Addresses Homebrew/discussions#659

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

`gdbserver` is actually being built on Linux, but not being installed. (`gdbserver` on macOS is not supported.)

`maybe-install-gdbserver` is a cross-platform GDB make target that Does The Right Thing on both macOS and Linux.

Addresses Homebrew/discussions#659
@BrewTestBot BrewTestBot added no ARM bottle Formula has no ARM bottle python Python use is a significant feature of the PR or issue labels Feb 3, 2021
@carlocab
Copy link
Member

carlocab commented Feb 3, 2021

If the change is a no-op, why the revision bump?

@gromgit
Copy link
Member Author

gromgit commented Feb 3, 2021

If the change is a no-op, why the revision bump?

Good point. I was thinking of Homebrew/brew#10099, but maybe I misinterpreted?

So should I move this PR to Linuxbrew, with revision 1 unless OS.mac??

@carlocab
Copy link
Member

carlocab commented Feb 3, 2021

Nah, I guess it's fine. I think we want to avoid divergence between homebrew-core and linuxbrew-core now anyway.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@gromgit gromgit deleted the gdb-install-server branch February 4, 2021 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no ARM bottle Formula has no ARM bottle python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants