rv: remove unneeded openssl dependency #258010
Open
+0
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
autosquash
Member
|
Please squash your commits into one commit. |
indirect
force-pushed
the
rv-remove-openssl
branch
2 times, most recently
from
f49e934 to
0344c56
Compare
github-actions
bot
removed
the
autosquash
Contributor
Author
|
Done. FYI, it's confusing that the commit style guide says both "If you can’t summarise it in 50 to 80 characters, you’re probably trying to commit two commits as one." and also says "Please squash your commits into one". I'm happy to do either, but it doesn't really seem possible to do both at the same time. |
chenrui333
reviewed
Dec 13, 2025
rv no longer depends on openssl, as a side effect of a pull request adding support for arch linux. that means we can remove this dependency. also remove install command. now that the run command automatically installs missing ruby versions, we don't need to explicitly install anything for the last command to succeed.
indirect
force-pushed
the
rv-remove-openssl
branch
from
0344c56 to
a14a441
Compare
daeho-ro
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?