Skip to content

Conversation

@anthumchris
Copy link
Contributor

@anthumchris anthumchris commented Dec 10, 2025

Adds a new keg-only versioned formula for GNU Privacy Guard gnupg v2.5.14 (release notes).

Should this package be considered cryptography and exempt from the error below? GNU Privacy Guard generates cryptographic encryption/signing/auth keys (via libcrypt). I commented out system "make", "check" to satisfy brew audit --strict --new [email protected].

Formulae in homebrew/core (except e.g. cryptography, libraries) should not run build-time checks

Feature parity is maintained with the Homebrew's curent release. Explicit pinentry path is not needed to build

[email protected] (this)                          gnupg
——————————————————————————————————————    ——————————————————————————————————————
                                          
GnuPG v2.5.14 has been                    GnuPG v2.4.8 has been
  configured as follows:                    configured as follows:
                                          
Revision:  4d993c37d  (19865)             Revision:  6f39568ae  (28473)
Platform:  Darwin                         Platform:  Darwin
                                          
OpenPGP:   yes                            OpenPGP:   yes
S/MIME:    yes                            S/MIME:    yes
Agent:     yes                            Agent:     yes
Smartcard: yes                            Smartcard: yes 
TPM:       no                             TPM:       no 
G13:       no                             G13:       no
Dirmngr:   yes                            Dirmngr:   yes
Keyboxd:   yes                            Keyboxd:   yes
Gpgtar:    yes                            Gpgtar:    yes
WKS tools: yes                            WKS tools: yes
                                          
Protect tool:       (default)             Protect tool:       (default)
LDAP wrapper:       (default)             LDAP wrapper:       (default)
Default agent:      (default)             Default agent:      (default)
Default pinentry:                         Default pinentry:
  /usr/local/opt/pinentry/bin/pinentry      /usr/local/opt/pinentry/bin/pinentry
Default scdaemon:   (default)             Default scdaemon:   (default)
Default keyboxd:    (default)             Default keyboxd:    (default)
Default tpm2daemon: (default)             Default tpm2daemon: (default)
Default dirmngr:    (default)             Default dirmngr:    (default)
                                          
Dirmngr auto start:  yes                  Dirmngr auto start:  yes
Readline support:    yes                  Readline support:    yes
LDAP support:        yes                  LDAP support:        yes
TLS support:         gnutls               TLS support:         gnutls
TOFU support:        yes                  TOFU support:        yes
Tor support:         yes                  Tor support:         yes

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core legacy Relates to a versioned @ formula labels Dec 10, 2025
@@ -0,0 +1,77 @@
class GnupgAT25 < Formula
# "this 2.5 series is fully supported and thus ready for production use"
# https://lists.gnupg.org/pipermail/gnupg-announce/2025q4/000499.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this announcement we should probably update the gnupg formula to 2.5 (and consider adding a [email protected]) instead.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few days ago, we decided not to. #257408

The status has not changed, the announcement as already that way for previous releases. But the homepage still lists it as “devel”:

Capture d’écran 2025-12-10 à 10 03 24

@fxcoudert
Copy link
Member

We ship versioned formulas in some cases, but usually for older versions, not for "pre-releases". This is a bit of a weird case.

@anthumchris
Copy link
Contributor Author

anthumchris commented Dec 10, 2025

should we rename to [email protected]? This provides the latest security/features to users while explicitly removing ambiguity.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 11, 2025
@anthumchris
Copy link
Contributor Author

new commit 3cfbe06 provides disambiguation, here's how it displays to users:

image

@anthumchris
Copy link
Contributor Author

closing until I resolve this failed test. possibly caused by excluding --with-pinentry-pgm --with-readline from build config

$ gpg --quick-generate-key --batch --passphrase '' test1@test

$ gpg --quick-generate-key --batch test2@test
gpg: agent_genkey failed: No pinentry
gpg: key generation failed: No pinentry

@anthumchris anthumchris reopened this Dec 11, 2025
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Dec 11, 2025
GnuPG v2.5 is the production-ready, fully-supported release that provides
post-quantum encryption (PQE) before becoming the official v2.6-stable release:
https://lists.gnupg.org/pipermail/gnupg-announce/2025q4/000499.html

- Name is correctly declared as "GNU Privacy Guard" (not "Pretty Good Privacy")
- All compile options are enabled except for TPM and G13
- Tests use the new default x25519 EdDSA/ECDH algorithms (succeeding RSA)
- desc uses "pre 2.6-stable" indicating this is not GnuPG's stable release
- homepage provides the URL with complete release disambiguation info
- added version "2.5.14-devel" for users to distinguish official GnuPG "stable"
- require pinentry dep to fix ensure passphrase entry
- use --with-pinentry-pgm, --with-readline to use Homebrew deps
- use tests for pinentry/readline availability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants