Skip to content

Conversation

@chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@Copilot Copilot AI review requested due to automatic review settings October 21, 2025 14:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new Homebrew formula for harbor-cli version 0.0.13, a CLI tool for managing Harbor container registries.

Key Changes:

  • New formula file introducing harbor-cli package
  • Build configuration with Go and version-embedded ldflags
  • Shell completion generation for bash, zsh, fish, and pwsh
  • Basic tests verifying version output and error handling

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 21, 2025
@botantony
Copy link
Member

Looks like it tries to access macOS keychain during installation and waits for user input, that's why it hangs
Screenshot 2025-10-21 at 18 10 02

@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 21, 2025
@chenrui333
Copy link
Member Author

Looks like it tries to access macOS keychain during installation and waits for user input, that's why it hangs

adding a upstream patch, goharbor/harbor-cli#562

@chenrui333 chenrui333 marked this pull request as draft October 21, 2025 18:25
@chenrui333 chenrui333 added the in progress Stale bot should stay away label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. go Go use is a significant feature of the PR or issue in progress Stale bot should stay away new formula PR adds a new formula to Homebrew/homebrew-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants