-
-
Couldn't load subscription status.
- Fork 13.2k
mandoc: install the libmandoc library #250236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cvengler
wants to merge
1
commit into
Homebrew:main
Choose a base branch
from
cvengler:libmandoc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not ship static-only libraries
https://docs.brew.sh/Acceptable-Formulae#shared-vs-static-libraries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is avoided, but if there is no option and is required by others, then I think we could.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would use it though? Even upstream discourages using that API, recommending simply invoking
mandocinstead.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am currently working on a roff toolchain in Rust. As far as I am aware, libmandoc is the only library that exists for the purpose.
I get your point, but given the monopoly of the library, I disagree.
Besides, I am using it to get an AST. While the mandoc program offers -Ttree, parsing this is rather inconvenient compared to a C tree structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if upstream actively tells people not to use the library, we shouldn't ship either.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree.
To me, what upstream is trying to imply is an eternal zerover and we do ship zerover things too.
Besides, development in mandoc is fairly slow these days, last release has been done 4 years ago.
Its not dead, the CVS repo has activity, but the release cycle is slow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is "telling people not to use it".
I think this is a case where we should install the library, avoid using it ourselves and provide a caveat instead. Perhaps we install to
libexecor something if we want to make it hard for us to use it ourselves.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, Linuxland is fairly undecided here.
Alpine for example packages it, Void Linux does not, and Debian does the Debian way by offering libmandoc-dev.
I think the decision of people to not package stems more from not knowing it exists, rather than actively refusing to, but that is an assumption, given the fact that it is rarely used.