Skip to content

charmcraft 4.0.1 #249934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

charmcraft 4.0.1 #249934

wants to merge 1 commit into from

Conversation

@BrewTestBot
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Oct 16, 2025
@chenrui333
Copy link
Member 

  ==> /home/linuxbrew/.linuxbrew/Cellar/charmcraft/4.0.1/bin/charmcraft version
  /home/linuxbrew/.linuxbrew/Cellar/charmcraft/4.0.1/libexec/lib/python3.14/site-packages/charmcraft/models/project.py:33: UserWarning: Core Pydantic V1 functionality isn't compatible with Python 3.14 or greater.
    import pydantic.v1
  charmcraft internal error: PermissionError(13, 'Permission denied')

@chenrui333 chenrui333 force-pushed the bump-charmcraft-4.0.1 branch from 3f0f0cc to 4ec7255 Compare October 16, 2025 23:47
@chenrui333 chenrui333 mentioned this pull request Oct 16, 2025
Merged
6 tasks
@BrewTestBot @chenrui333
charmcraft 4.0.1
27b8c87 
charmcraft: downgrade to py3.13

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 force-pushed the bump-charmcraft-4.0.1 branch from 4ec7255 to 27b8c87 Compare October 16, 2025 23:55
@daeho-ro daeho-ro mentioned this pull request Oct 17, 2025
Open
43 tasks
@chenrui333 chenrui333 added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Oct 17, 2025
@daeho-ro daeho-ro added linux Linux is specifically affected linux-arm Linux ARM is specifically affected labels Oct 18, 2025
@chenrui333
Copy link
Member

Looks like only linux tests failed, gonna file an upstream report.

@chenrui333 chenrui333 mentioned this pull request Oct 18, 2025
Open
@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Oct 18, 2025
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Oct 20, 2025
@chenrui333 chenrui333 added in progress Stale bot should stay away and removed stale No recent activity labels Oct 21, 2025
lengau
lengau reviewed Oct 23, 2025
View reviewed changes
Formula/c/charmcraft.rb
resource "pydantic" do
url "https://files.pythonhosted.org/packages/3c/a7/d0d7b3c128948ece6676a6a21b9036e3ca53765d35052dbcc8c303886a44/pydantic-2.12.1.tar.gz"
sha256 "0af849d00e1879199babd468ec9db13b956f6608e9250500c1a9d69b6a62824e"
url "https://files.pythonhosted.org/packages/8d/35/d319ed522433215526689bad428a94058b6dd12190ce7ddd78618ac14b28/pydantic-2.12.2.tar.gz"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise it would be preferable to keep these external dependencies in sync with the uv.lock file in the main repo

lengau
lengau reviewed Oct 23, 2025
View reviewed changes
Formula/c/charmcraft.rb
depends_on "libyaml"
depends_on "pygit2" => :no_linkage
depends_on "python@3.14"
depends_on "python@3.13" # craft-cli not yet compatible with py3.14, https://github.com/canonical/craft-cli/issues/360
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly it's probably for the best if you keep this in sync with the snap, since that's where charmcraft is most widely tested. That would mean Python 3.12 until we upgrade the snap to the core26 base sometime next year (at which point it would be 3.14).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@botantony botantony botantony approved these changes

+1 more reviewer

@lengau lengau lengau left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. in progress Stale bot should stay away linux Linux is specifically affected linux-arm Linux ARM is specifically affected python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue upstream issue An upstream issue report is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BrewTestBot @chenrui333 @lengau @botantony @daeho-ro