[WIP] Fix zap tests

[claui]

Summary

The zap command has test coverage issues as pointed out in #21607.
This WIP branch is to discuss, investigate, and ultimately fix those issues.

I have added a temporary rake test:zap command for convenience.

How to run the isolated test

1. Go to your local repo.
2. Check out the branch:
   git fetch [email protected]:claui/homebrew-cask.git refs/heads/fix-zap-tests && git checkout FETCH_HEAD
   (This will leave all your existing remotes/branches alone; it will not even add a remote.)
3. Run the isolated test:
   bundle exec rake test:zap

[claui]

For starters, I have uncommented the first few lines of the failing test:

  it "dispatches both uninstall and zap stanzas" do
    with_zap = Hbc.load('with-zap')

    # shutup do
      Hbc::Installer.new(with_zap).install
    # end
  # […]
  end

and this already fails. Disarming the sudo part does not help:

    # shutup do
      Hbc::Installer.new(with_zap,
        command: Hbc::NeverSudoSystemCommand).install
    # end

In either case, /usr/sbin/installer causes an error:

installer: Error the package path specified was invalid:
'/var/folders/9k/72bcsqxd55q00scw81pt2f6h0000gp/T/homebrew_tests20160601-35211-cx84y/prefix/TestCaskroom/with-zap/1.2.3/MyFancyPkg/Fancy.pkg'.

I have double-checked whether Fancy.pkg is actually there.
Also, when I run installer manually on Fancy.pkg, I get the same error.

Any ideas?

[fanquake]

What's the status here? Should this be rebased and Travis re-run?

[claui]

@fanquake Good point. This is not really urgent but I agree in that we shouldn’t ever take test coverage lightly.

I’ll rebase by the end of the week if no one else does.

[jawshooah]

@claui would you like to try applying these changes on Homebrew/brew?

[claui]

@jawshooah As soon as I’m through my backlog, I will reopen and apply as suggested!

[jawshooah]

Thanks, no rush! Just wanted to get our PRs to Inbox Zero since we're so tantalizingly close! 😲