Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mullvadvpn: fetch from github #198273

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

yasinuslu
Copy link
Contributor

@yasinuslu yasinuslu commented Jan 14, 2025

Notes

I've noticed that the mullvadvpn's cdn is really slow (maybe it is slow in my region, not sure). Thought it would be better to use their artifact in github instead.


Checkboxes

  • The submission is for a stable version or documented exception.
  • brew audit --cask --online <cask> is error-free.
    • I have trouble running this because I use nix-darwin
    • I am checking the box because CI seemed to have ran that with no issues on both intel and arm
  • brew style --fix <cask> reports no offenses.

@yasinuslu yasinuslu marked this pull request as ready for review January 14, 2025 23:44
Copy link
Member

@samford samford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave the decision of whether to switch the cask url source up to the cask maintainers but I've added a livecheck block suggestion in case we go forward with this.

For what it's worth, I can't remember if this is a consistent issue or just a short-term fluke but the most recent version was noticeably slow to download for me as well.

Casks/m/mullvadvpn.rb Outdated Show resolved Hide resolved
@khipp khipp added the livecheck Issues or PRs related to livecheck label Jan 15, 2025
Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@khipp khipp merged commit f138838 into Homebrew:master Jan 15, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants