Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iexplorer: fix livecheck #198238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eleanordoesntcode
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:


Page is not a classic sparkle update file and so the livecheck failed there.

@khipp khipp added the livecheck Issues or PRs related to livecheck label Jan 14, 2025
@khipp
Copy link
Member

khipp commented Jan 14, 2025

The response format seems to be inconsistent. It's alternating between plain text and XML.

Casks/i/iexplorer.rb Outdated Show resolved Hide resolved
Co-authored-by: Klaus Hipp <[email protected]>
@eleanordoesntcode
Copy link
Contributor Author

In either case, the regex here with this strategy works, whereas the previous one only worked when the server returned XML.

@krehel
Copy link
Member

krehel commented Jan 14, 2025

Is this software still functional? The appcast has not been updated since 2022 and is 2 major iOS versions behind current. It also appears to rely on iTunes, according to the website.

@eleanordoesntcode
Copy link
Contributor Author

I'll try it on my machine, 1 second

@eleanordoesntcode
Copy link
Contributor Author

App seems to be working fine, I tested it with my iPhone SE on the latest iOS version and it worked mostly fine - I wasn't able to access the music but I'm assuming that's due to the fact my iCloud account isn't on my computer and therefore cannot decrypt the songs.

@krehel
Copy link
Member

krehel commented Jan 14, 2025

Thanks @eleanordoesntcode. If the regex works I am fine with it, we can't fix upstream returning two different formats. I'l tag @samford for his thoughts.

@krehel krehel requested a review from samford January 14, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants