-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display-pilot 1.5.0.0_Mac_250102090118 (new cask) #198207
Open
dlackty
wants to merge
1
commit into
Homebrew:master
Choose a base branch
from
dlackty:display-pilot
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
cask "display-pilot" do | ||
version "1.5.0.0_Mac_250102090118" | ||
sha256 "deef444a8d9a32ac75939862e0e32ead901f04099a696a8a85dd60944f58aa85" | ||
|
||
url "https://esupportdownload.benq.com/esupport/VERTICAL%20&%20PROFESSIONAL%20DISPLAY/Software/Display%20Pilot%202/Display%20Pilot%202%20for%20Mac_V#{version}.zip" | ||
name "Display Pilot 2" | ||
desc "Streamlines display control: brightness, inputs, pivot, and more" | ||
homepage "https://www.benq.com/en-ap/monitor/software/display-pilot-2.html" | ||
|
||
livecheck do | ||
skip "No reliable way to get version info" | ||
end | ||
|
||
depends_on macos: ">= :big_sur" | ||
|
||
app "Display Pilot 2.app" | ||
|
||
zap trash: "~/Library/Preferences/com.benq.DisplayPilot2.plist" | ||
end |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can do with page match from
by the download url.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the suggestion! Unfortunately, using page match isn’t feasible because the content on the page is rendered on the front end. Additionally, the API endpoint (https://www.benq.com/api/esupport-tm/getFiles/en_gb/display%20pilot%202/en_gb,ge_ge) requires an
Accept-Encoding
header and returns 401 otherwise. (Weird design?)Let me know if there’s an alternative approach you’d recommend!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a url provided by the in-app updater that only include the version number - https://qspublic.s3.ap-southeast-1.amazonaws.com/qspublic/qs_app/1001/Display Pilot 2Setup-1.5.0.0-release.dmg
If that link is suitable for the url, we can find the latest version using the spec page for
livecheck
- https://www.benq.com/en-ap/monitor/software/display-pilot-2/spec.htmlWe tend not to include software without a reliable
livecheck
inhomebrew-cask
, as the maintenance burden is less when the versions can be updated and checked systematically.