Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display-pilot 1.5.0.0 (new cask) #198207

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

dlackty
Copy link
Contributor

@dlackty dlackty commented Jan 14, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@dlackty
Copy link
Contributor Author

dlackty commented Jan 14, 2025

I spent several hours searching for a reliable livecheck source. The app updater uses a signature in the header for authentication, while the webpage relies on a front-end fetch to an API that also validates cookies for authentication.

Given these constraints, I had to omit the livecheck block.

Casks/d/display-pilot.rb Outdated Show resolved Hide resolved
Casks/d/display-pilot.rb Outdated Show resolved Hide resolved
@dlackty dlackty force-pushed the display-pilot branch 3 times, most recently from adc2396 to b8d5c75 Compare January 15, 2025 18:48
@dlackty dlackty changed the title display-pilot 1.5.0.0_Mac_250102090118 (new cask) display-pilot 1.5.0.0 (new cask) Jan 15, 2025
Casks/d/display-pilot.rb Outdated Show resolved Hide resolved
@bevanjkay bevanjkay requested a review from samford January 15, 2025 21:12
Casks/d/display-pilot.rb Outdated Show resolved Hide resolved
Casks/d/display-pilot.rb Outdated Show resolved Hide resolved
@bevanjkay
Copy link
Member

Thank you @dlackty 🎉

@bevanjkay bevanjkay merged commit 9f07092 into Homebrew:master Jan 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants