Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guitar-pro: install full package #198164

Merged
merged 1 commit into from
Jan 14, 2025
Merged

guitar-pro: install full package #198164

merged 1 commit into from
Jan 14, 2025

Conversation

bevanjkay
Copy link
Member

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

When guitar-pro was updated to use a versioned url (see #192833), a lighter version of the installer was used, which does not include all the features that were previously available. This PR updates the cask to use the full installer, and aligns with the download found in the appcast.

Closes #198102

@khipp khipp enabled auto-merge January 14, 2025 09:39
@khipp khipp merged commit 754ca41 into master Jan 14, 2025
11 checks passed
@khipp khipp deleted the guitar-pro-url-update branch January 14, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

guitar-pro RSE soundbanks not included
2 participants