Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

badlion-client 4.5.1 #197991

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zyoshoka
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@zyoshoka zyoshoka force-pushed the bump-badlion-client-4.5.1 branch from df38345 to 83603c0 Compare January 12, 2025 15:17
@p-linnane p-linnane added the upstream Issue which needs to be resolved by the upstream project. label Jan 14, 2025
Comment on lines 14 to 15
url "https://client-updates.badlion.net/latest-mac.yml"
strategy :electron_builder
url "https://www.badlion.net/download/client/latest/mac"
strategy :header_match
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can revert the livecheck changes, yml seems fixed now!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I check the wrong url. I ask them again.

@khipp khipp removed the upstream Issue which needs to be resolved by the upstream project. label Jan 15, 2025
@zyoshoka zyoshoka force-pushed the bump-badlion-client-4.5.1 branch from 83603c0 to fe11c16 Compare January 15, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants